[
https://issues.apache.org/jira/browse/CXF-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319511#comment-15319511
]
Sergey Beryozkin edited comment on CXF-6869 at 6/7/16 9:53 PM:
---------------------------------------------------------------
Hi Vedran
Np, thanks for the comments.
Having a property seems marginally more preferable. In the current patch it is
conditional on the application not initiating a "jaxRsServer" bean, so if we
have a manual setup with multiple CXF endpoints then the users would be
somewhat restricted to having at least a single "jaxRsServer" bean as opposed
to say "myApplicationEndpoint", etc.
Probably a minor issue. But having a property also ensures there will be no
unexpected auto-discovery going under the hood. This property can be enabled
by default over time if it is what people would prefer in their feedbacks.
If we have a property approach, I believe the only thing which would change as
far as your last patch is concerned, is that instead we'd have Conditional
checking the property is set, right ?
Re the recommended approach, yes, as I said I'm fine with the current module
structure, and adhering to the blueprint is good, but I'd like to re-iterate
that the CXF specifics may need to be taken into the consideration, from the
CXF point of view pushing JAX-WS and JAX-RS specifics into a single
auto-configure module will not be a clean solution. But for now the only
specifics we have is a JAX-RS auto-scan feature so I guess we can indeed enable
it via an optional property.
What I did not quite get, I tried a jaxws demo with your patch which enables
the jaxrs auto discovery and it worked fine without me adding a JAX-RS dep, how
does it work if the auto-configure feature has Conditional on
JAXRSServerFactoryBean.class ?
Yeah, lets chat about Spring cloud later on. I have an action item to check if
the fact we have a CXF endpoint up in SpringBoot makes it visible in other
specific Spring servers, such as the registry. I'll give it a try later on...
Thanks
was (Author: sergey_beryozkin):
Hi Vedran
Np, thanks for the comments.
Having a property seems marginally more preferable. In the current patch it is
conditional on the application not initiating a "jaxRsServer" bean, so if we
have a manual setup with multiple CXF endpoints then the users would be
somewhat restricted to having at least a single "jaxRsServer" bean as opposed
to say "myApplicationEndpoint", etc.
Probably a minor issue. But having a property also ensures there will be no
unexpected auto-discovery going under the hood. This property can be enabled
by default over time if it is what people would prefer in their feedbacks.
If we have a property approach, I believe the only thing which would change as
far as your last patch is concerned, is that instead we'd have Conditional
checking the property is set, right ?
Re the recommended approach, yes, as I said I'm fine with the current module
structure, and adhering to the blueprint is good, but I'd like to re-iterate
that the CXF specifics may need to be taken into the consideration, from the
CXF point of view pushing JAX-WS and JAX-RS specifics into a single
auto-configure module will not be a clean solution. But for now the only
specifics we have is a JAX-RS auto-scan feature so I guess we can indeed enable
it via an optional property.
What I did not quite get, I tried a jaxws demo with your patch which enables
the jaxrs auto discovery and it worked fine without me adding a JAX-RS dep, how
does it work if out auto-configure has Conditional on
JAXRSServerFactoryBean.class ?
Yeah, lets chat about Spring cloud later on. I have an action item to check if
the fact we have a CXF endpoint up in SpringBoot makes it visible in other
specific Spring servers, such as the registry. I'll give it a try later on...
Thanks
> Consider adding Spring Boot starter
> -----------------------------------
>
> Key: CXF-6869
> URL: https://issues.apache.org/jira/browse/CXF-6869
> Project: CXF
> Issue Type: New Feature
> Components: Integration
> Reporter: Vedran Pavic
> Assignee: Sergey Beryozkin
>
> I've recently authored a PR in Spring Boot to add support for
> auto-configuration of {{CXFServlet}} and default CXF's configuration:
> https://github.com/spring-projects/spring-boot/pull/5659
> The PR was closed with "won't fix" resolution since Boot team are unwilling
> to add CXF as a dependency to the project. Instead a 3rd party starter was
> suggested.
> The concept of a 3rd party starter is generally encouraged for technologies
> that don't have first-class support in projects from Spring portfolio. Such
> 3rd party starters are listed here:
> https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/README.adoc
> If CXF team is interested, I'm willing to port my PR to CXF.
> Note that the original PR was focused around JAX-WS support, but can be
> easily expanded to include JAX-RS support as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
