[ https://issues.apache.org/jira/browse/CXF-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093857#comment-15093857 ]
Sergey Beryozkin commented on CXF-6729: --------------------------------------- Neal, thanks for the patience/effort, it looks good to me. I might do a couple of small tweaks afterwards. Iris, please go ahead with your commit. This is how I usually do it (starting from master, 3.2.0-SNAPSHOT): 1. git pull 2. git commit -a --message "[CXF-6729] Your commit message" 3. git push origin master then on 3.1.x: 1. git pull 2. git cherry-pick commit-number (you will see it from your commit to the master) 3. git push origin 3.1.x-fixes and finally on 3.0.x: 1. git pull 2. git cherry-pick commit-number (you will see it from your commit to 3.1.x-fixes) 3. git push origin 3.0.x-fixes Before committing to the master: do 'mvn clean install' in rt/frontend/jaxrs and systests/jaxrs at least Thanks, Sergey > Version 1 NewCookie is not compliant with RFC 2109 > --------------------------------------------------- > > Key: CXF-6729 > URL: https://issues.apache.org/jira/browse/CXF-6729 > Project: CXF > Issue Type: Bug > Components: JAX-RS > Affects Versions: 3.0.7, 3.1.4 > Environment: Windows > Reporter: Neal Hu > Fix For: 3.1.5, 3.0.8 > > Attachments: NewCookieHeaderProvider.java, > NewCookieHeaderProvider.patch, NewCookieHeaderProviderTest.java, > NewCookieHeaderProviderTest.patch, ResponseImplTest.java > > > Hi, > From http://www.ietf.org/rfc/rfc2109.txt and > http://stackoverflow.com/questions/572482/why-do-cookie-values-with-whitespace-arrive-at-the-client-side-with-quotes > the version 1 cookie look like: name="value with > spaces";Max-Age=3600;Path="/";Version=1 > NewCookieHeaderProvider.toString(NewCookie) has not handled the special > characters(RFC2068) that need around with quotes -- This message was sent by Atlassian JIRA (v6.3.4#6332)