[
https://issues.apache.org/jira/browse/CXF-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562680#comment-14562680
]
ASF GitHub Bot commented on CXF-6424:
-------------------------------------
GitHub user skjolber opened a pull request:
https://github.com/apache/cxf/pull/76
[CXF-6424] AbstractLoggingInterceptor tests and improvements
See JIRA issue for further details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skjolber/cxf origin/prettyprint2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit e9d356b1165ce2c531bed0090864304aeaabfebc
Author: Thomas Skjølberg <thomas.skjolb...@gmail.com>
Date: 2015-05-27T23:57:01Z
Update pretty-printing for XML payloads
commit bc2a2484ebea7736c9324fb42b4ee0f4a3099bf5
Author: Thomas Skjølberg <thomas.skjolb...@gmail.com>
Date: 2015-05-28T09:40:27Z
Additional test cases for logging interceptors
commit 984472707e1edb15eb130f5574e898a409ef687d
Author: Thomas Skjølberg <thomas.skjolb...@gmail.com>
Date: 2015-05-28T10:03:32Z
Improve class name
----
> AbstractLoggingInterceptor tests and improvements
> -------------------------------------------------
>
> Key: CXF-6424
> URL: https://issues.apache.org/jira/browse/CXF-6424
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Reporter: Thomas Skjølberg
> Priority: Minor
>
> Improvements for AbstractLoggingInterceptor:
> 1. fall back to logging raw XML payload if pretty-printing fails
> 2. ensure capacity in the output based on the raw XML string size
> 3. write directly (and improve performance) to the output StringBuilder using
> custom Writer
> 4. read directly (and improve performance) from the StringWriter buffer using
> custom Reader
> 5. contruct XMLStreamReader directly rather than going via Source
> 6. do not call XMLStreamWriter.close() before getting contents for truncated
> or invalid XML because some writers misbehave (are extra helpful) in a way
> unfit for logging.
> 7. additional javadoc / comments
> 8. additional test cases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
