[
https://issues.apache.org/jira/browse/CXF-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089469#comment-14089469
]
Piotr Klimczak edited comment on CXF-5118 at 8/7/14 5:15 PM:
-------------------------------------------------------------
In reference to
https://github.com/cschneider/cxf/commit/bc436011e99084b5e2f1165b70aa4cf028a49a1a
{code}
public List<CallbackHandlerProvider> getCallbackHandlerProviders() {
return callbackHandlerProviders;
}
public void setCallbackHandlerProviders(List<CallbackHandlerProvider>
callbackHandlerProviders) {
this.callbackHandlerProviders.clear();
this.callbackHandlerProviders.addAll(callbackHandlerProviders);
}
{code}
It will be very uncomfortable for users.
Most of them will probably use Spring or Blueprint, which means they will not
be able to add just one new CallbackHandlerProvider to the end of the list,
because existing content will be replaced with setCallbackHandlerProviders. And
can't see a way to get a list with getCallbackHandlerProviders and add just one
element to it from spring/blueprint.
So if they really want to add just one (at the end for example), they will be
forced to explicitly add all already existing plus one new. It will be error
prone as default list of callback providers may change with next releases.
Not sure how to make it easier with Spring/Blueprint
It is simply not spring/blueprint friendly approach.
If I would be the user, I would rather write new class that extends
JAASLoginInterceptor, to handle adding just one CallbackProvider where I want
to safely.
Not sure is this what we want to.
I know that previously I agreed it might be good idea. But I missed the fact
that configurability will be more complicated then.
was (Author: nannou9):
In reference to
https://github.com/cschneider/cxf/commit/bc436011e99084b5e2f1165b70aa4cf028a49a1a
{code}
public List<CallbackHandlerProvider> getCallbackHandlerProviders() {
return callbackHandlerProviders;
}
public void setCallbackHandlerProviders(List<CallbackHandlerProvider>
callbackHandlerProviders) {
this.callbackHandlerProviders.clear();
this.callbackHandlerProviders.addAll(callbackHandlerProviders);
}
{code}
It will be very uncomfortable for users.
Most of them will probably use Spring or Blueprint, which means they will not
be able to add just one new CallbackHandlerProvider to the end of the list,
because existing content will be replaced with setCallbackHandlerProviders. And
can't see a way to get a list with getCallbackHandlerProviders and add just one
element to it from spring/blueprint.
So if they really want to add just one (at the end for example), they will be
forced to explicitly add all already existing plus one new. It will be error
prone as default list of callback providers may change with next releases.
Not sure how to make it easier with Spring/Blueprint
It is simply not spring/blueprint friendly approach.
If I would be the user, I would rather write new class that extends
JAASLoginInterceptor, to handle adding just one CallbackProvider where I want
to safely.
Not sure is this what we want to.
I know that previously I agreed it might be good idea. But I missed the fact
that reconfigurability will be more complicated then.
> Create CXF interceptor which will use HTTPS client certificates to create
> JAAS SecurityContext
> -----------------------------------------------------------------------------------------------
>
> Key: CXF-5118
> URL: https://issues.apache.org/jira/browse/CXF-5118
> Project: CXF
> Issue Type: New Feature
> Components: Core
> Reporter: Sergey Beryozkin
> Assignee: Christian Schneider
>
> Use case:
> The user authenticates against the webservice using an X509 client
> certificate. In case of successful authentication the JAAS security context
> should be populated with a Subject that stores the user name and the roles of
> the user. This is necessary to support Authorization at a later stage.
> Design ideas
> The SSL transport will be configured to only accept certain client
> certificates. So we can assume that the interceptor does not have to do a
> real authentication. Instead it has to map from the subjectDN of the
> certificate to the user name and then lookup the roles of that user. Both
> then has to be stored in the subject's principles.
> The mapping could be done inside a JAASLoginModule or before. Inside will
> give the user more flexibility.
> The next step to retrieve the roles should be done in one of the standard
> JAASLoginModules as the source of the roles can be quite diverse. So for
> example the LdapLoginModule allows to retrieve the roles from Ldap. At the
> moment these modules require the password of the user though which is not
> available when doing a cert based auth.
> So I see two variants to retrieve the roles:
> 1. Change the loginmodules like the LDAP one to be configureable to use a
> fixed ldap user for the ldap connect and not require the user password. So
> the module would have two modes: a) normal authentication and group gathering
> b) use a fixed user to just retrieve roles for a given user
> 2. Store the user password somewhere (e.g. in the mapping file). In this case
> the existing LDAPLoginModule could be used but the user password would be
> openly in a text file
> 3. Create new LoginModules with the desired behaviour (fixed user and only
> lookup of roles)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
