SoapTransportFactory: confused exception by unknown transport protocol
----------------------------------------------------------------------

                 Key: CXF-3961
                 URL: https://issues.apache.org/jira/browse/CXF-3961
             Project: CXF
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.5
         Environment: Windows
            Reporter: Andrei Shakirin
            Priority: Minor
         Attachments: SoapTransportFactory.patch

If custom transport conduit is resolved via 
SoapTransportFactory.getConduit(EndpointInfo ei) and transport is not found in 
ConduitInitiatorManager, following exception is thrown:

java.lang.NullPointerException
        at 
org.apache.cxf.binding.soap.SoapTransportFactory.getConduit(SoapTransportFactor
y.java:228)[131:org.apache.cxf.bundle:2.4.2]

The reason is following: ConduitInitiatorManager.getConduitInitiatorForUri() 
doesn't throw BusException in case if transport is not found, therefore line 
"return conduitInit.getConduit(ei)" throws NPE.

I see two possible solutions:
A) throw BusException in ConduitInitiatorManager.getConduitInitiatorForUri() in 
the same way as ConduitInitiatorManager.getConduitInitiator()
B) Check for null in SoapTransportFactory

(A) is risky, because it has invluence on all calls of 
ConduitInitiatorManager.getConduitInitiatorForUri()
Patch for (B) is attached.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to