[
https://issues.apache.org/jira/browse/CXF-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930197#action_12930197
]
Aki Yoshida commented on CXF-3114:
----------------------------------
Hi Freeman,
Okay.
There is another thing that I forgot to mention in my post. With the above
change, RMTxStore can load the stored sequences.
The other part that needs to be fixed is the part that actually recovers the
stored destination sequences for each endpoint after restart.
In RMManager, currently, its recoverReliableEndpoint method which gets called
at the startup recovers only the source sequences but no destination sequences.
In order for the server to recognize the persisted sequences, the destination
sequences must be also loaded into the Destination associated with each
endpoint.
So I made some changes in my local copy of RMManager to solve this issue.
The original code fragment
{code}
void recoverReliableEndpoint(Endpoint endpoint, Conduit conduit) {
...
Collection<SourceSequence> sss = store.getSourceSequences(id);
if (null == sss || 0 == sss.size()) {
return;
}
LOG.log(Level.FINE, "Number of source sequences: {0}", sss.size());
RMEndpoint rme = null;
for (SourceSequence ss : sss) {
Collection<RMMessage> ms = store.getMessages(ss.getIdentifier(),
true);
if (null == ms || 0 == ms.size()) {
continue;
}
LOG.log(Level.FINE, "Number of messages in sequence: {0}",
ms.size());
if (null == rme) {
LOG.log(Level.FINE, "Recovering {0} endpoint with id: {1}",
new Object[] {null == conduit ? "client" : "server",
id});
rme = createReliableEndpoint(endpoint);
rme.initialise(conduit, null);
reliableEndpoints.put(endpoint, rme);
}
rme.getSource().addSequence(ss, false);
for (RMMessage m : ms) {
...
}
}
retransmissionQueue.start();
}
{code}
The changed fragment that includes the loading of the destination sequences
{code}
void recoverReliableEndpoint(Endpoint endpoint, Conduit conduit) {
...
Collection<SourceSequence> sss = store.getSourceSequences(id);
Collection<DestinationSequence> dss = store.getDestinationSequences(id);
if ((null == sss || 0 == sss.size()) && (null == dss || 0 ==
dss.size())) {
return;
}
LOG.log(Level.FINE, "Number of source sequences: {0}", sss.size());
LOG.log(Level.FINE, "Number of destination sequences: {0}", dss.size());
LOG.log(Level.FINE, "Recovering {0} endpoint with id: {1}",
new Object[] {null == conduit ? "client" : "server", id});
RMEndpoint rme = createReliableEndpoint(endpoint);
rme.initialise(conduit, null);
reliableEndpoints.put(endpoint, rme);
for (SourceSequence ss : sss) {
Collection<RMMessage> ms = store.getMessages(ss.getIdentifier(),
true);
if (null == ms || 0 == ms.size()) {
continue;
}
LOG.log(Level.FINE, "Number of messages in sequence: {0}",
ms.size());
rme.getSource().addSequence(ss, false);
for (RMMessage m : ms) {
...
}
}
for (DestinationSequence ds : dss) {
rme.getDestination().addSequence(ds, false);
}
retransmissionQueue.start();
}
{code}
I would like to hear your comment on this because I am not sure if this is the
right place for loading the stored destination sequences.
If you think this change is appropriate, I can create a "svn diff" file for the
changes.
Thanks.
Regards, Aki
> WS-RM's RMTxStore's does not recover stored sequences after restart
> -------------------------------------------------------------------
>
> Key: CXF-3114
> URL: https://issues.apache.org/jira/browse/CXF-3114
> Project: CXF
> Issue Type: Bug
> Environment: CXF 2.2.11 with Derby 10.6.2.1
> Reporter: Aki Yoshida
> Assignee: Freeman Fang
>
> When WS-RM's derby storage is activated, the sequence data are persisted in
> the database.
> However, these sequence data are not loaded from the database when the WS-RM
> component is restarted.
> This problem appears to be caused by the init method of the persistence class
> org.apache.cxf.ws.rm.persistence.jdbc.RMTxStore which leaves an uncommitted
> transaction to the relevant tables open. Consequently, the next select
> statement that loads the persisted sequence data is not seeing the content.
> The original source code fragment of this method looks like this:
> {code}
> try {
> connection.setAutoCommit(false);
> createTables();
> } catch (SQLException ex) {
> LogUtils.log(LOG, Level.SEVERE, "CONNECT_EXC", ex);
> SQLException se = ex;
> while (se.getNextException() != null) {
> se = se.getNextException();
> LogUtils.log(LOG, Level.SEVERE, "CONNECT_EXC", se);
> }
> throw new RMStoreException(ex);
> }
> {code}
> The suggested change would be as follows:
> {code}
> try {
> connection.setAutoCommit(true);
> createTables();
> } catch (SQLException ex) {
> LogUtils.log(LOG, Level.SEVERE, "CONNECT_EXC", ex);
> SQLException se = ex;
> while (se.getNextException() != null) {
> se = se.getNextException();
> LogUtils.log(LOG, Level.SEVERE, "CONNECT_EXC", se);
> }
> throw new RMStoreException(ex);
> } finally {
> try {
> connection.setAutoCommit(false);
> } catch (SQLException ex) {
> LogUtils.log(LOG, Level.SEVERE, "CONNECT_EXC", ex);
> throw new RMStoreException(ex);
> }
> }
> {code}
> In the above code, the setAutoCommit(true) statement could be omitted if we
> simply want to rely on the default autoCommit mode.
> In any case, the suggested code makes sure that the subsequence statement is
> correctly executed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
