[
https://issues.apache.org/jira/browse/CXF-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794753#action_12794753
]
Gary Gregory commented on CXF-2594:
-----------------------------------
-----Original Message-----
From: Gary Gregory [mailto:ggreg...@seagullsoftware.com]
Sent: Tuesday, December 22, 2009 13:31
To: Daniel Kulp; us...@cxf.apache.org
Subject: RE: Inflexible fault interceptor chain?
Hi All:
I am trying to build SVN 2.2.x (I just updated from SVN) to test a patch (I do
not have a test yet) just to see what happens if SAAJOutInterceptor uses a
W3CDOMStreamWriter even if the local variable is null. Since that caused a test
to hang I thought I'd try to build an unchanged 2.2.6 as a baseline. I get the
errors below when I run:
mvn clean install -Peverything
Does 2.2.x build ok for anyone out there?
Results :
Failed tests:
testExcludeNSWithPackageName(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBug305924ForNestedBinding(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testParameterOrderNoOutputMessage(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testParameterOrderDifferentNS(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
Tests in error:
testHelloWorldExternalBindingFile(org.apache.cxf.tools.wsdlto.jaxws.CodeGenOptionTest)
testFlagForGenStandAlone(org.apache.cxf.tools.wsdlto.jaxws.CodeGenOptionTest)
testFlagForGenAdditional(org.apache.cxf.tools.wsdlto.jaxws.CodeGenOptionTest)
testHeaderFromAnotherMessage1(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHeaderFromAnotherMessage2(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHeaderFromAnotherMessage3(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHeaderFromAnotherMessage4(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHeaderFromAnotherMessage5(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testRPCLit(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testAsyncMethod(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testAsyncMethodNoService(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHelloWorldSoap12(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHelloWorld(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHelloWorldWithDummyPlugin(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testDocLitHolder(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testSchemaImport(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testExceptionNameCollision(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testAllNameCollision(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testImportNameCollision(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testSoapHeader(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHolderHeader(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWSAddress(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testVoidInOutMethod(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWsdlImport(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWebFault(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testMultiSchemaParsing(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testDefaultParameterOrder(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testSupportXMLBindingBare(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testSupportXMLBindingWrapped(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testRouterWSDL(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWSDLContainsJavaKeywords(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWSDLWithEnumType(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testSWAMime(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testRPCHeader(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testRefTNS(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWebFaultAnnotaion(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testGlobalBinding(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testXmlSeeAlso(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWSAction(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testHandlerAnnotation(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testGenerateXmlListAnno(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testWrapperWithWildcard(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testCXF1950(org.apache.cxf.tools.wsdlto.jaxws.CodeGenTest)
testLogicalOnlyWSDL(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBug305729(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBug305773(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBug305700(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testNamespacePackageMapping1(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testNamespacePackageMapping2(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testNamespacePackageMapping3(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBug305772(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCommandLine(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testLocatorWithJaxbBinding(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testWsdlNoService(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testNoServiceImport(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testServiceNS(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testNoServiceNOPortType(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testDefatultNsMap(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testDefatultNsMapExclude(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testHelloWorldExternalBindingFile(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testWebResult(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCXF627(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testRecursiveImport(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCXF804(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testDefinieServiceName(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testAntFile(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testAsyncImplAndClient(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testZeroInputOutOfBandHeader(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBindingForImportWSDL(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testReuseJaxwsBindingFile(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testBindingXPath(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testJaxbCatalog(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCatalog2(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCatalog3(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testServer(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testTwoJaxwsBindingFile(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testJaxwsBindingJavaDoc(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testWSAActionAnno(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCXF964(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCXF1620(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testCXF1048(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
testJaxbNpa(org.apache.cxf.tools.wsdlto.jaxb.JAXBCodeGenOptionTest)
Tests run: 124, Failures: 4, Errors: 82, Skipped: 1
> No SOAP fault XML elements when a Fault is thrown in the output chain after
> SAAJOutInterceptor
> ----------------------------------------------------------------------------------------------
>
> Key: CXF-2594
> URL: https://issues.apache.org/jira/browse/CXF-2594
> Project: CXF
> Issue Type: Bug
> Affects Versions: 2.2.4
> Environment: java version "1.6.0_16"
> Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
> Java HotSpot(TM) 64-Bit Server VM (build 14.2-b01, mixed mode)
> Microsoft Windows [Version 6.0.6002]
> Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
> Java version: 1.6.0_16
> Java home: C:\Program Files\Java\jdk1.6.0_16\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows"
> Eclipse 3.6M4:
> Version: 3.6.0
> Build id: I20091210-1301
> Reporter: Gary Gregory
> Fix For: 2.2.6
>
>
> The attached unit test runs on top of the 2.2.x SVN branch updated from SVN
> as of now.
> This ticket originated with this thread:
> http://old.nabble.com/Inflexible-fault-interceptor-chain--td26840876.html
> Which I replicate here with comments used for each step:
> Hi All:
> I need to apply an XSL transformation to messages coming out of CXF (our
> users configure what the XSL looks like.) For a normal (successful) message,
> I have an interceptor (during Phase.PRE_MARSHAL) that uses the DOM aspect of
> a message. That works great. BTW, I get to the DOM like this:
> Node node = (Node) message.getContent(List.class).get(0);
> That seems brittle, is there a safer way to get to an aspect of the message I
> can feed to javax.xml.transform?
> The real issue comes with fault messages because the fault chain uses an
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>.
> The fault chain looks like this:
> Chain org.apache.cxf.phase.phaseinterceptorch...@3015b303. Current flow:
> setup [ServerPolicyOutFaultInterceptor]
> prepare-send [MessageSenderInterceptor, Soap11FaultOutInterceptor]
> pre-stream [LoggingOutInterceptor, XmlDeclOutInterceptor*,
> StaxOutInterceptor]
> pre-protocol [WebFaultOutInterceptor, SOAPHandlerFaultOutInterceptor]
> write [SoapOutInterceptor]
> pre-marshal [LogicalHandlerFaultOutInterceptor]
> marshal [Soap11FaultOutInterceptorInternal]
> pre-stream-ending [StaxOutEndingInterceptor, TransformOutFaultInterceptor*]
> prepare-send-ending [MessageSenderEndingInterceptor]
> FYI, the interceptors marked with * are our own:
> * XmlDeclOutInterceptor forces an XML declaration to be written.
> * TransformOutFaultInterceptor is where I thought I could transform
> the fault XML message.
> The
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>
> looks like this:
> [StreamWriter: class com.ctc.wstx.sw.SimpleNsStreamWriter, underlying
> outputter:
> com.ctc.wstx.sw.isolatin1xmlwri...@1125cf44<mailto:com.ctc.wstx.sw.isolatin1xmlwri...@1125cf44>
> The com.ctc.wstx.sw.ISOLatin1XmlWriter wraps a
> org.apache.cxf.io.CachedOutputStream, which in turns wraps:
> * currentStream - LoadingByteArrayOutputStream
> * flowThroughStream - AbstractHTTPDestination$WrappedOutputStream
> All of this to say that when the chain's interceptors are working with the
> message's
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>,
> the bytes are cached and written to the wire. It is not possible to catch
> the fault XML message and change it.
> The only thing I've come up with but not implemented yet would be to insert
> an interceptor before the XML declaration is written and put the
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>
> into a temp spot in the message content map, then put a new
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>
> on a byte array in its place. A pre-stream-ending interceptor can take those
> bytes, apply XSL to them and then write them to the original
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>,
> before putting the original
> XMLStreamWriter<http://java.sun.com/javase/6/docs/api/javax/xml/stream/XMLStreamWriter.html>
> back in it original slot in the message content map.
> That seems like big old hack.
> Any ideas on a cleaner solution?
> Thank you,
> Gary Gregory
> Seagull Software
> ggreg...@seagullsoftware.com
> www.seagullsoftware.com
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
