[ 
https://issues.apache.org/jira/browse/CXF-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675339#action_12675339
 ] 

bazzargh edited comment on CXF-2053 at 2/20/09 3:59 AM:
-----------------------------------------------------------

This (untested) patch demonstrates logging failures in each of the 5 rules for 
wrapped operations. Its possible to change the code more to get more detailed 
information about the failure, but this keeps the change to one class. I'd have 
preferred to use the verbose switch from ToolContext, rather than just logging 
at 'info' level, but I've only seen cxf's code by debugging this issue so I'm 
not sure if that is available to me here.

The messages paraphrase the rules a bit in an effort to keep them to one line. 
In particular rule 5 is hard to explain in a compact way, I resorted to xpath. 
If multi-line messages are acceptable, quoting the spec verbatim would be 
better as it is google-able for people wanting to find out more.

      was (Author: bazzargh):
    This (untested) patch demonstrates logging failures in each of the 5 rules 
for wrapped operations. Its possible to change the code more to get more 
detailed information about the failure, but this keeps the change to one class. 
I'd have preferred to use the verbose switch from ToolContext, rather than just 
logging at 'info' level, but I've only seen cxf's code by debugging this issue 
so I'm not sure if that is available to me here.

The messages paraphrase the 5 rules a bit in an effort to keep them to one 
line. In particular rule 5 is hard to explain in a compact way, I resorted to 
xpath. I multi-line messages are acceptable, quoting the spec verbatim would be 
better as it is google-able for people wanting to find out more.
  
> wsdl2java should log reason for switching from wrapped to bare in verbose mode
> ------------------------------------------------------------------------------
>
>                 Key: CXF-2053
>                 URL: https://issues.apache.org/jira/browse/CXF-2053
>             Project: CXF
>          Issue Type: Improvement
>          Components: Tooling
>         Environment: All
>            Reporter: Brian Ewins
>            Priority: Minor
>         Attachments: local_history.patch
>
>
> When developing a WSDL-first service, a fairly common issue is to find that 
> the wsdl2java code generates bare rather than wrapped style. This happens 
> because you've broken the rules in 2.3.1.2 of the jax-ws spec, but finding 
> out why can be hard to trace down - if any parameter in the service cannot be 
> wrapped, then the entire service will be generated bare.
> At the moment the only ways to figure out what has gone wrong are manual 
> inspection, or debugging cxf (or asking someone else/the mailing list to help 
> with one of those tasks). It would make much more sense if cxf could tell us 
> why its not going to generate wrapped code, particularly when invoked with 
> -verbose.
> Strawman patch follows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to