[
https://issues.apache.org/jira/browse/CXF-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639397#action_12639397
]
Benson Margulies commented on CXF-1859:
---------------------------------------
I think this is fine as it is. The policy about tests does not call for unit
tests for complete trivia. If you were felling really frisky, you could find
and mtom test in systests and add a case for this, but testing the MessageUtils
just for this strikes me as silly.
> mtom-enabled property case sensitive
> ------------------------------------
>
> Key: CXF-1859
> URL: https://issues.apache.org/jira/browse/CXF-1859
> Project: CXF
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.0.8
> Environment: jdk1.5
> Reporter: Adrian Corcoran
> Priority: Minor
> Attachments: MessageUtils.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Setting of jax-ws endpoint property mtom-enabled is case sensitive - setting
> value to 'TRUE' rather than 'true' will not enable mtom.
> The root of this problem is in MessageUtils.
> public static boolean isTrue(Object value) {
> if (Boolean.TRUE.equals(value) || "true".equals(value)) {
> return true;
> }
>
> return false;
> }
> This should obviously be
> public static boolean isTrue(Object value) {
> return Boolean.valueOf(value.toString());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
