[
https://issues.apache.org/jira/browse/CB-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355797#comment-14355797
]
ASF GitHub Bot commented on CB-8595:
------------------------------------
GitHub user kamrik opened a pull request:
https://github.com/apache/cordova-lib/pull/183
CB-8595 Merge platforms.js from cordova & plugman CB-8595
Till now we had two separate places for platform specific code
cordova/metadata exposed via cordova/platforms.js
plugman/platforms exposed via plugman/platforms.js
This change merges the two `platforms.js` files into
`platforms/platforms.js`
containing a single class exposing functionality from both places.
The class is instantiated via
prj = platforms.getPlatformProject(platform, project_dir)
`prj` can then be used just like the platform parsers were used before in
cordova
e.g. `prj.www_dir()` or the handlers in plugman e.g:
`prj.parseProjectFile()`.
This is a compatibility layer so that the platform specific code could be
easier consolidated and eventually moved to the platform repos.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamrik/cordova-lib platformcode-CB-8595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit df7240aa119aa7024cb1a7644de836b5f59e26c0
Author: Mark Koudritsky <kam...@gmail.com>
Date: 2015-03-10T21:31:06Z
CB-8499 Merge platforms.js from cordova and plugman
Till now we had two separate places for platform specific code
cordova/metadata exposed via cordova/platforms.js
plugman/platforms exposed via plugman/platforms.js
This change merges the two `platforms.js` files into
`platforms/platforms.js`
containing a single class exposing functionality from both places.
The class is instantiated via
prj = platforms.getPlatformProject(platform, project_dir)
`prj` can then be used just like the platform parsers were used before in
cordova
e.g. `prj.www_dir()` or the handlers in plugman e.g:
`prj.parseProjectFile()`.
This is a compatibility layer so that the platform specific code could be
easier consolidated and eventually moved to the platform repos.
commit 7932bd729b8846033ff2767ebaa7bab17fd8d4b9
Author: Mark Koudritsky <kam...@gmail.com>
Date: 2015-03-10T21:43:12Z
CB-8499 Fix tests for unified platforms.js change
----
> Merge platform specific code into one place
> -------------------------------------------
>
> Key: CB-8595
> URL: https://issues.apache.org/jira/browse/CB-8595
> Project: Apache Cordova
> Issue Type: Improvement
> Reporter: Mark Koudritsky
> Assignee: Mark Koudritsky
>
> Currently we have two separate places for platform specific code
> src/cordova/metadata
> src/plugman/platforms
> This is confusing.
> Once consolidated the platform specific code will be much easier to move to
> the platform repos where it belongs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
