GitToTheHub commented on code in PR #1663:
URL: https://github.com/apache/cordova-ios/pull/1663#discussion_r4069431310
##########
templates/project/App.xcodeproj/project.pbxproj:
##########
@@ -414,16 +417,19 @@
"INSTALL_PATH[sdk=macosx*]" =
"$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)";
"INSTALL_PATH[sdk=xrsimulator*]" =
"$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)";
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
+ "IPHONEOS_DEPLOYMENT_TARGET[sdk=*27.*]" = 15.0;
LOCALIZATION_PREFERS_STRING_CATALOGS = YES;
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
SDKROOT = iphoneos;
STRING_CATALOG_GENERATE_SYMBOLS = YES;
+ SUPPORTED_PLATFORMS = "iphonesimulator iphoneos
xros xrsimulator";
SUPPORTS_MACCATALYST = YES;
SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
SWIFT_COMPILATION_MODE = wholemodule;
- TARGETED_DEVICE_FAMILY = "1,2";
+ TARGETED_DEVICE_FAMILY = "1,2,6,7";
Review Comment:
AI noted here:
> The generated Cordova app now inherits Mac Catalyst and visionOS support.
In templates/project/App.xcodeproj/project.pbxproj, project-level settings
change TARGETED_DEVICE_FAMILY from 1,2 (iPhone/iPod touch, iPad) to 1,2,6,7
(iPhone/iPod touch, iPad, Mac Catalyst, visionOS) and add `xros` (visionOS)
platforms. This affects the consumer App target, not just the Cordova package
target.
Is this change intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
