erisu opened a new pull request, #164: URL: https://github.com/apache/cordova-browser/pull/164
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Consolidate `cordova-serve` functionality in `cordova-browser` ### Description <!-- Describe your changes in detail --> * Dropped `cordova-serve` dependency from `cordova-browser` * Re-implement with bare minimum requirements. * Added npm packages `express` and `compression` for serving content content * Added npm package `open` for automatic opening of browser support * Only browser that `open` support will be supported. The following browsers are supported: brave, chrome, edge, firefox, safari. This does not include release variations, e.g. Chrome canary, Firefox Developer Edition, etc. * If additional browser support is needed, the recommendation is to submit an issue ticket to the `open` package. * Alternatively , `--target=none` can be passed to disable automatic opening of the browser and the app developer can manually open the browser of choice. * Added npm package `string-dedent` (`String.dedent` TC39 proposal) * Other repos had used `dedent` but I believe the above package is preferred as it was created by one of the champions for the `String.dedent` TC39 proposal. * Added/updated printout notice: * Serving is a development, for testing only, feature. * Recommend app developers to use their own setup for advance debugging features. * Added HTTPS/SSL Support (User must supply key & cert via run args) * `--ssl-key-file=/path/to/key` * `--ssl-cert-file=/path/to/cert` TODO: * Write tests ### Testing <!-- Please describe in detail how you tested your changes. --> Build app and use `cordova run browser` command. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
