breautek commented on issue #1967:
URL: 
https://github.com/apache/cordova-android/issues/1967#issuecomment-4907137221

   > I think it's still a bit too early to rely solely on safe-area-inset-top, 
since it's only available starting with WebView 149, which was released just a 
couple of months ago. https://caniuse.com/mdn-css_types_env_safe-area-inset-top
   
   I agree -- that's why I mention using a plugin to bridge that gap. At my 
workplace we use https://github.com/totalpaveinc/cordova-plugin-insets to do 
this, which does something pretty close to what your statusbar fork does.
   
   I think on my apps the statusbar stays white -- but I don't have the 
statusbar plugin installed anymore either so perhaps that's why? I'll test and 
try to track down exactly what or how the status bar color gets decided.
   
   > Maybe we can add a workaround for --safe-area-inset-* beeing 0? The 
article 
https://medium.com/androiddevelopers/make-webviews-edge-to-edge-a6ef319adfac 
shows how to set --safe-area-inset-* css variables by JavaScript from the 
native code.
   
   I would refrain adding in workarounds in the core framework especially when 
it's expected to be temporarily. Such workarounds should be in a plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to