jcesarmobile opened a new pull request, #1963: URL: https://github.com/apache/cordova-android/pull/1963
onExceededDatabaseQuota was deprecated on Android API 19 and has no effect https://developer.android.com/reference/android/webkit/WebChromeClient#onExceededDatabaseQuota(java.lang.String,%20java.lang.String,%20long,%20long,%20long,%20android.webkit.WebStorage.QuotaUpdater) shouldOverrideUrlLoading was deprecated on Android API 24, replaced it with `shouldOverrideUrlLoading ([WebView](https://developer.android.com/reference/android/webkit/WebView) view, [WebResourceRequest](https://developer.android.com/reference/android/webkit/WebResourceRequest) request)` https://developer.android.com/reference/android/webkit/WebViewClient#shouldOverrideUrlLoading(android.webkit.WebView,%20java.lang.String) onReceivedError was deprecated on Android API 24, replaced it with `onReceivedError ([WebView](https://developer.android.com/reference/android/webkit/WebView) view, [WebResourceRequest](https://developer.android.com/reference/android/webkit/WebResourceRequest) request, [WebResourceError](https://developer.android.com/reference/android/webkit/WebResourceError) error)` https://developer.android.com/reference/android/webkit/WebViewClient#onReceivedError(android.webkit.WebView,%20int,%20java.lang.String,%20java.lang.String) shouldInterceptRequest was deprecated on Android API 21, we already have the newer method implemented, so just deleted the old one. But note that the removed one had some checks that we no longer do such as `shouldAllowRequest`. setGeolocationDatabasePath was deprecated on Android API 24, while the comment says "// @todo remove when Cordova drop API level 24 support", if it's deprecated in 24 we should not use it in 24. Not sure if it **could be considered breaking**, pretty sure `shouldOverrideUrlLoading` and `onReceivedError` have no effect at the moment and introducing the non deprecated ones might change behaviors, but they are old behaviors that are not working at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
