erisu opened a new pull request, #174: URL: https://github.com/apache/cordova-node-xcode/pull/174
- Add `PBXBuildFile` entry to `filePathToBuildFile` lookup table when a valid identifier is present. - Valid identifier is determined when the `fileReference` has either a `path` or `name` property value. - The `path` property takes priority when both `path` and `name` are defined. - When the `path` and `name` properties are not defined the entry is not added to the lookup table. --- Additionally, this PR - Added some in-code documentation. - Using JSDocs - Added a basic example --- The main purpose of this PR is to resolve and close PR #140. PR #140 was attempting to resolve a failure that occurred when looping through build files to create the `filePathToBuildFile` lookup table, where a file reference did not have `path` defined. The PR attempted to resolve this by skipping when the `path` property of the file reference was missing. There are cases where `name` can be used instead of `path`. In those cases, `name` appears to serve as the file path, with path resolution determined by the file reference's `sourceTree`. But generally, `name` often matches the file name. Same issue was reported here: https://github.com/apache/cordova-ios/issues/1357 This PR takes a different approach and check if either `path` or `name` is defined before it skipped the build file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
