dpogue commented on code in PR #1955:
URL: https://github.com/apache/cordova-android/pull/1955#discussion_r3398285402
##########
cordova-js-src/plugin/android/statusbar.js:
##########
@@ -60,25 +60,24 @@ Object.defineProperty(statusBar, 'setBackgroundColor', {
statusBarScript.style.color = value;
var rgbStr =
window.getComputedStyle(statusBarScript).getPropertyValue('color');
- if (!rgbStr.match(/^rgb/)) { return; }
-
- var rgbVals = rgbStr.match(/\d+/g).map(function (v) { return
parseInt(v, 10); });
+ if (!rgbStr.match(/^rgb/)) {
+ return;
+ }
Review Comment:
I find the one-line `if` and `return` much harder and slower to read at a
glance because it doesn't visually look like a conditional block due to the
lack of indenting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
