dpogue opened a new pull request, #1662:
URL: https://github.com/apache/cordova-ios/pull/1662

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The Cordova iOS 8.1.0 minor release is missing a `__CORDOVA_8_1_0` macro in 
CDVAvailability.h.
   
   Closes #1660
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Add a unit test to confirm the a macro is defined that matches the current 
version from package.json. This means the macro will need to be added when a 
dev version bump happens, and a missing version at tagging time will result in 
test failures.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   1. Ran tests with missing macro and ensured they failed.
   2. Added the macros.
   3. Ran tests and ensured that they succeeded.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to