GitToTheHub commented on PR #937:
URL:
https://github.com/apache/cordova-plugin-camera/pull/937#issuecomment-3704445039
@dpogue Thanks for reviewing this. There were some changes still necessary i
noticed later:
- `sourceType` `SAVEDPHOTOALBUM` opens also the PHPicker now
- Documentation of `takePicture` and `showCameraPicker` in `CDVCamera.m`
- Removed documentation for `takePicture` in header file. The documentation
is done in the `.m` file
- Removed unnecessry `dispatch_async(dispatch_get_main_queue() ...` in
`takePicture` before calling `showCameraPicker`. This is already done in
`showCameraPicker`.
- Source out code for permission denied alert dialog when accessing the
camera or `UIImagePickerController` on iOS < 14 for picking images
- I updated the readme
- Better document usage descriptions
- `NSPhotoLibraryUsageDescription` not needed for iOS 14+ when only
picking images
- Improve formatting for xml, js
- sourceType `SAVEDPHOTOALBUM` is the same as `PHOTOLIBRARY` on Android
and iOS 14+
- Use `PHOTOLIBRARY` as sourceType instead of `SAVEDPHOTOALBUM` in photo
picker example
- I made subtle changes on the Android side in `CameraLauncher.java`
- Make clear that `SAVEDPHOTOALBUM` is the same like `PHOTOLIBRARY` and
has only an effect on iOS < 14
- Format code when creating image chooser and document the request code
parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
