erisu opened a new pull request, #281:
URL: https://github.com/apache/cordova-paramedic/pull/281

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   n/a
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   - Remove local tunneling package and flag which is unmaintained and has an 
issue
   - Remove remote external server flag
   
   This tool was primarily used internally for Cordova’s plugin testing and 
never relied on these features. They may have originally been added for 
SauceLabs device testing, but since SauceLabs support has been removed, I 
believe these features can be removed as well.
   
   With a small fix, that will be submitted in a separate PR, it has been 
confirmed that device testing still works, as long as it runs locally.
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Removed `localtunnel` package, flags, and remote external server,
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   - `npm run test-ios`
   - `npm run test-android`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to