erisu commented on PR #1852: URL: https://github.com/apache/cordova-android/pull/1852#issuecomment-3433334146
I guess we can add back the deprecated API that you are using in this PR. When I tested, I saw no difference with or without it in a default Cordova project on SDK 34 and 28. I guess there is no harm to include it. In another test, I removed the `<item name="android:statusBarColor">@android:color/transparent</item>` to see how it also behaves, with and without the API. It appears to behave the same and looks correct. But, there is a visual visual glitch but this is not in Cordova's scope since Cordova uses transparent by default. For advance users who decide to make custom themes, they would have to manage it on their end to prevent the glitch. For example, if they set the status bar color to yellow in `config.xml` they will have to update the custom theme to match. Basically they need to manage two locations. Users who uses default Cordova, they only need to manage via preference flag. The glitch in the video you will see it going from purple (splash screen) -> black status bar -> yellow status bar. | Test Case | Result | | -- | -- | | Cordova Default (Transparent StatusBar Theme Setting Without Deprecated API) | [TransparentStatusBarThemeWithoutAPI.webm](https://github.com/user-attachments/assets/35cff7e4-ac2f-43c2-805f-d9db3305873d) | | Cordova Default (Transparent StatusBar Theme Setting With Deprecated API) | [TransparentStatusBarThemeWithAPI.webm](https://github.com/user-attachments/assets/01e8fd5e-1b53-48fe-a6ef-c44ed719b3a2) | | Removed Transparent StatusBar Theme Setting Without Deprecated API | [NoStatusBarThemeWithOutAPI.webm](https://github.com/user-attachments/assets/1542078a-b255-451b-aeb4-ffb149f018de) | | Removed Transparent StatusBar Theme Setting With Deprecated API | [NoStatusBarThemeWithAPI.webm](https://github.com/user-attachments/assets/8a519945-7181-4430-8e53-1eedbd211c49) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
