Chuckytuh opened a new pull request, #1847: URL: https://github.com/apache/cordova-android/pull/1847
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context With the changes added on https://github.com/apache/cordova-android/pull/1817, when the app is in edge to edge mode or fullscreen, the left and right margin values are being read directly from the insets thus causing the webview to not take the full width/height in fullscreen or not be overlaid by navigation/gesture bar when rotation the device. It's unclear to me whether this was intentional but, if it wasn't, this is an attempt to fix it to what I'd expect is the correct behavior. ### Description <!-- Describe your changes in detail --> ### Testing Created a dummy application and manually ran it on Android 10 and 16 and compared the results visually. Current behavior: | | non-e2e | e2e | fullscreen | |------------|----------|--------|--------| | Android 16 | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 55 50" src="https://github.com/user-attachments/assets/412ed1e1-6f9c-413d-988c-664193e26d8d"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 55 58" src="https://github.com/user-attachments/assets/58f911a1-6ecb-494e-954d-6d839be03b75"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 57 26" src="https://github.com/user-attachments/assets/24112a2c-1e9e-48de-80dc-8af31fb262c4"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 57 35" src="https://github.com/user-attachments/assets/ea3176f3-c2f2-4e57-b040-fcf39b190c7d"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 58 45" src="https://github.com/user-attachments/assets/ea8109e9-0433-4cce-98a2-e1110329335a"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 58 51" src="https://github.com/user-attachments/assets/edf8daad-d8e5-43b2-b7a7-703f3e435b55"; /> | | Android 10 | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 56 32" src="https://github.com/user-attachments/assets/529ce5a1-1a16-42fd-8ec8-a394f4feabfa"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 56 36" src="https://github.com/user-attachments/assets/1c9ec477-201a-424d-8210-33a948334ac4"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 58 04" src="https://github.com/user-attachments/assets/4d0e1a3b-8757-4f98-990e-9995b64383d4"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 58 09" src="https://github.com/user-attachments/assets/a9952d0a-8071-428c-9fe9-4e73e06a88ce"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 59 06" src="https://github.com/user-attachments/assets/ff2c5f57-a824-417a-8956-817bb01d7d56"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 20 59 10" src="https://github.com/user-attachments/assets/6ceb5f08-1913-488d-b97b-e4a53a026f66"; /> | Behavior after the fix on this PR: | | non-e2e | e2e | fullscreen | | ---------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | Android 16 | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 00 12" src="https://github.com/user-attachments/assets/738c416d-f1d5-4e35-907e-0317073dc929"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 00 22" src="https://github.com/user-attachments/assets/f8f2f67f-75f6-4d98-9b80-845e8e144e2d"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 01 07" src="https://github.com/user-attachments/assets/bb8c6c8f-868a-4e6d-9247-bede2f6a47a1"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 01 12" src="https://github.com/user-attachments/assets/87765d65-15da-4fb8-9ec1-cbc6cc8fa2ee"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 02 48" src="https://github.com/user-attachments/assets/a301ce80-1d4d-4496-a592-519205118a34"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 02 52" src="https://github.com/user-attachments/assets/b4cadf6a-36dd-4e16-8f79-4806e263e99e"; /> | | Android 10 | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 00 48" src="https://github.com/user-attachments/assets/2777dca3-24d6-4e3a-b74f-eed7dbf8e095"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 00 53" src="https://github.com/user-attachments/assets/78f0afb9-27ef-4a3a-bfe0-95e340826a14"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 01 31" src="https://github.com/user-attachments/assets/4fc4cc5a-57a3-4473-921d-560d713a290e"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 01 45" src="https://github.com/user-attachments/assets/c2c291ed-8625-49cf-ba48-12e6ccf5ecee"; /> | <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 03 36" src="https://github.com/user-attachments/assets/37e9f2d1-b15d-49f4-b343-2bee39c803c3"; /> <img width="1912" height="1237" alt="Screenshot 2025-10-07 at 21 03 40" src="https://github.com/user-attachments/assets/e630e3e9-387d-406b-91fd-f77abb2e2dec"; /> | ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
