erisu commented on code in PR #1563: URL: https://github.com/apache/cordova-ios/pull/1563#discussion_r2374439367
########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build Review Comment: ```suggestion ## Install Nightly Build ``` Title/Header formatting and adding space between header and content. ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes Review Comment: ```suggestion ### Notes ``` - New line between header ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes +We do not recommend using nightly in production releases. In-fact we can not suggest using as they don't go though an official release voting process. But people can use it to test and confirm if changes that landed in the main branch to see if it resolved any issues they have or test for potential new issues to report on. + +Sometimes a nightly build could be missing for a few reasons but the main two reasons are: +- GitHub deactivates our cron task because the repo hasnt has any activity over a period of time. We just have to restart the cron task. This might happen ever 3 months. +- NPM cached and didnt detect one of our nightly releases so a another package that relied on it couldnt be fetched and failed. Review Comment: ```suggestion ``` ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes +We do not recommend using nightly in production releases. In-fact we can not suggest using as they don't go though an official release voting process. But people can use it to test and confirm if changes that landed in the main branch to see if it resolved any issues they have or test for potential new issues to report on. + +Sometimes a nightly build could be missing for a few reasons but the main two reasons are: +- GitHub deactivates our cron task because the repo hasnt has any activity over a period of time. We just have to restart the cron task. This might happen ever 3 months. +- NPM cached and didnt detect one of our nightly releases so a another package that relied on it couldnt be fetched and failed. + +See more regarding nightly builds: https://cordova.apache.org/contribute/nightly_builds.html Review Comment: ```suggestion See [Apache Cordova - Nightly Builds](https://cordova.apache.org/contribute/nightly_builds.html) for more details. ``` Small refactor. ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes +We do not recommend using nightly in production releases. In-fact we can not suggest using as they don't go though an official release voting process. But people can use it to test and confirm if changes that landed in the main branch to see if it resolved any issues they have or test for potential new issues to report on. + +Sometimes a nightly build could be missing for a few reasons but the main two reasons are: Review Comment: ```suggestion ``` I removed the lined about missing nightly. This type of information is not needed in this README. ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes +We do not recommend using nightly in production releases. In-fact we can not suggest using as they don't go though an official release voting process. But people can use it to test and confirm if changes that landed in the main branch to see if it resolved any issues they have or test for potential new issues to report on. + +Sometimes a nightly build could be missing for a few reasons but the main two reasons are: +- GitHub deactivates our cron task because the repo hasnt has any activity over a period of time. We just have to restart the cron task. This might happen ever 3 months. Review Comment: ```suggestion ``` ########## README.md: ########## @@ -65,6 +65,20 @@ npm install npm test ``` +## Install nightly build +```bash +cordova platform add ios@nightly +``` + +### Notes +We do not recommend using nightly in production releases. In-fact we can not suggest using as they don't go though an official release voting process. But people can use it to test and confirm if changes that landed in the main branch to see if it resolved any issues they have or test for potential new issues to report on. Review Comment: ```suggestion Nightly builds are **not recommended for production apps**. They are intended for testing purposes—either to check if recent changes in the main branch have fixed existing issues, or to identify new bugs before an official release. Nightly builds are generated daily and may be **unstable**. ``` Shortened the text to be more concise. - I made sure that "not recommended" was bold so its clear to not use for production. - Shortened the intended purpose of nightly builds. - Added line that nightly builds are generated daily and could be unstable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
