breautek commented on PR #191: URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3397595971
> I thought the engines tag is obsolete in config.xml. Nope, it's not obsolete. It controls some checks on the Cordova CLI, and/or platforms when installing cordova plugins. Where the engines inside `package.json` NPM controls checks on the NodeJS/npm runtime. > Also the configuration "cordova": ">100" seems odd to me. In this case, it's set to CLI requirement `>100` (which doesn't exist) on v4 of this plugin (which also doesn't currently exist). The rationale is that it forces whoever does a major version bump to also pay attention to the engines block and to set it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
