dpogue opened a new pull request, #229: URL: https://github.com/apache/cordova-common/pull/229
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected all ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> nyc doesn't seem to be as actively maintained as we'd like, and pulls in dependencies that have raised licence questions (although they are not distributed as part of the package) c8 is an alternative that relies on node itself to provide coverage information rather than trying to inject instrumentation into the code ### Description <!-- Describe your changes in detail --> * Move from nyc to c8 * Improve code coverage of a few files * Replace lodash.zip with an inline version. Lodash no longer recommends using the individual module versions of its packages and instead suggests pulling in the full lodash package, but we literally only need 1 line of code in one place ### Testing <!-- Please describe in detail how you tested your changes. --> All tests run, code coverage is generated ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
