dpogue opened a new pull request, #1540:
URL: https://github.com/apache/cordova-ios/pull/1540

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Closes GH-1530.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Try to safely clean up empty directories when uninstalling plugin assets 
without always forcibly removing the plugin directory itself. This should 
provide better handling for cases where plugins have multiple assets that get 
added to the plugin folder.
   
   The `removeFileAndParents` function is already used for uninstall plugin JS 
module files.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Updated existing tests (minimally) and they are passing.
   
   Have not testing in an actual project with an affected plugin
   (/cc @cdm-tao if you are able to give this a try and report back)
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to