breautek commented on issue #209: URL: https://github.com/apache/cordova-plugin-device/issues/209#issuecomment-2844969306
I'm not so sure if this a good idea. I would definitely be supportive of making these methods private if this was a new package but giving that this is a really old plugin that's always had public members, there could be systems that depends on these. A third-party plugin (or even native workflow app) could fetch the plugin instance from `PluginManager` and use the public APIs directly. While that definitely wouldn't be a common practice, I'm not sure if value of making these methods/properties private for proper encapsulation outweighs the risk of breaking third-party code that may depend on the public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
