erisu opened a new pull request, #1793: URL: https://github.com/apache/cordova-android/pull/1793
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Resolves #1792 ### Description <!-- Describe your changes in detail --> Before Android Studio 3.5, Gradle was bundled with the IDE. In the past, for Windows environments, we attempted to locate the Android Studio installation path to use its bundled Gradle executable. However, Cordova has not supported old versions of Android Studio for a long time, making this logic obsolete. Additionally, past release announcements have indicated increasing Android Studio requirements: - Cordova-Android 13 required a minimum of Android Studio Jellyfish. - Cordova-Android 14 required a minimum of Android Studio Ladybug. Documentation also stated that since Cordova-Android 6.4.0, a system-level Gradle installation is required. Cordova would then uses this to generate the project-level Gradle wrapper. Given these changes, this PR will remove the outdated Windows-specific logic. The `.bat` file will remain for now but will be removed in the next major release. ### Testing <!-- Please describe in detail how you tested your changes. --> - Create cordova project in a directory with spaces - Added cordova platform which contains this PR changes. - Built app with `cordova build android` command on Windows. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
