erisu opened a new pull request, #1411: URL: https://github.com/apache/cordova-docs/pull/1411
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: https://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Resolves #1278 ### Description <!-- Describe your changes in detail --> - Fix regex to replace `.md` to `.html` in `all-pages.yml` generation. - Remove `console.log` that affected `all-pages.yml` content. - Get the current page full URL with `page.path` and format it with a prefixed `/` and converted `.md` to `.html`. - Fixed page detection when checking against `all-pages.yml`. ### Testing <!-- Please describe in detail how you tested your changes. --> **Built Docs:** - `bundle install` - `npm install` - `npm run serve` **Navigated to an old doc:** - `http://localhost:3000/docs/en/8.x/guide/cli/index.html` **Observations:** 1. Outdated Version Warning: The link for "This version of the documentation is outdated! Click here for the latest released version." points to `http://localhost:3000/docs/en/latest/guide/cli/index.html`. **Note**: Clicking on this link will not work because the `latest` redirection is handled by `.htaccess`, and `serve` is not running an Apache Httpd server. 2. 12.x Version Link: The link for `12.x` in the version dropdown points to `http://localhost:3000/docs/en/12.x/guide/cli/index.html`. Clicking on this link will perform a redirect to the correct page. 3. 2.8.0 Version Link: The link for `2.8.0` is grayed out since this version does not have a mapping for the current page. The link points to `http://localhost:3000/docs/en/2.8.0/`. Clicking on this link will redirect to the root page of version 2.8.0. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
