erisu commented on PR #1781: URL: https://github.com/apache/cordova-android/pull/1781#issuecomment-2728463739
> we should do is copy the generated gradle, gradlew, and gradlew.bat files up a directory on each gradle wrapper install into platforms/android/. This PR now copy up a directory as suggested. > If the wrapper files already exists, then it should be replaced. This should be complete. It always runs a copy with recursive+force on build. > experiment with creating a symlink Symlink will not be used because we need to ensure that the files remain when the platforms directory are zipped. It seems that there is a use case to prepare the platforms in one environment and built in another. > We should also retain the tools/ gradle wrapper copy for future install commands. Done > Android Studio will use the wrapper installed at platforms/android/. The CLI could continue to use the wrapper in platforms/android/tools/ CLI uses tools version. > CLI should make sure that platforms/android/ gradle install is identical to the one inside platform/android/tools/ CLI should always call the install gradle wrapper method and copy step during build. This would handle the case if users changes the version by preference. This PR does not, and will not, cover the cases if the users upgrades from android studio. CLI build will undo those changes and replace grade back with tools version. This PR will not cover creating of the gradle wrapper on `platform add`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
