erisu opened a new pull request, #1408: URL: https://github.com/apache/cordova-docs/pull/1408
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: https://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fix redirect for archived docs ### Description <!-- Describe your changes in detail --> Updated the `RewriteRules` to follow these steps, in order: 1. Stop rewrite when URL starts with `/archive/`. 2. Stop rewrite when URL starts with `/docs/en/`. 3. Forward non-English docs to English docs. Additional Notes: - Step three has always been designed to redirect old language documentation to the English version. - However, it is possible to change this behavior to redirect them to the archived language documentation instead, **if preferred**. (Would be in a separate PR) - However, since this redirection behavior has been in place for several years, changing it now may no longer be necessary. - If old versions of the English documentation are to be archived, the `RewriteRule` should be placed above step two. In this case, it would redirect to archive. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran a httpd server to test the RewriteRules. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
