breautek commented on code in PR #1778:
URL: https://github.com/apache/cordova-android/pull/1778#discussion_r1951014326
##########
lib/check_reqs.js:
##########
@@ -110,7 +110,9 @@ module.exports.get_gradle_wrapper = function () {
let program_dir;
// OK, This hack only works on Windows, not on Mac OS or Linux. We will
be deleting this eventually!
if (module.exports.isWindows()) {
- const result = execa.sync(path.join(__dirname, 'getASPath.bat'));
+ // "spawn" option enabled for CVE-2024-27980 (Windows) Mitigation
Review Comment:
```suggestion
// "shell" option enabled for CVE-2024-27980 (Windows) Mitigation
```
I wrote in "spawn" because that was in the original PR but since we
determine the "shell" option is correct, that should be reflected in the
comment too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
