erisu commented on code in PR #1772:
URL: https://github.com/apache/cordova-android/pull/1772#discussion_r1932642342
##########
lib/builders/ProjectBuilder.js:
##########
@@ -342,15 +342,15 @@ class ProjectBuilder {
const args = this.getArgs('clean', opts);
return execa(wrapper, args, { stdio: 'inherit', cwd:
path.resolve(this.root) })
.then(() => {
- fs.removeSync(path.join(this.root, 'out'));
+ fs.rmSync(path.join(this.root, 'out'));
Review Comment:
It was not exactly clear if "out" was a directory or file.
I thought this was an output log file.
I could not find in code where this directory or file is being created. But
looking at the test spec, it refers to it as a directory.
If correct, adding `{ recursive: true, force: true }` is required, which I
just pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
