kumo01GitHub opened a new pull request, #290: URL: https://github.com/apache/cordova-plugin-geolocation/pull/290
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> fix #257 ### Description <!-- Describe your changes in detail --> Desynchronize `isLocationServicesEnabled` As comment, this change might cause some problems because of run in thread that location manager is not created in. Especially, around [this line](https://github.com/kumo01GitHub/cordova-plugin-geolocation/blob/ef045076bd6b696a244ece6d1fbf115b436a3f16/src/ios/CDVLocation.m#L141) (change updating location status and accuracy) are suspecious. But I have no idea that critical situation that incorrect behavior that caller JS application cannot (or should not) handle. If there are some problems about above, I will close this PR. If there are no problem, I will remove TODO comment before you marge. ### Testing <!-- Please describe in detail how you tested your changes. --> I did simple operation confirmation with simulator. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
