NoLongerBreathedIn opened a new issue, #220:
URL: https://github.com/apache/cordova-common/issues/220

   # Bug Report
   
   ## Problem
   `ConfigChanges.prototype.add_config_changes` crashes if you have any 
`config-file` elements in your `config.xml`.
   ### What is expected to happen?
   It handles it properly.
   
   
   ### What does actually happen?
   It crashes with an error saying that a path was null.
   
   
   ## Information
   
   ### Command or Code
   ```
   <config-file target="AndroidManifest.xml" mode="merge" 
parent="/manifest/application/activity"
                xmlns:android="http://schemas.android.com/apk/res/android"; 
platform="android">
        <intent-filter>
                <action android:name="android.media.action.IMAGE_CAPTURE"/>
        </intent-filter>
   </config-file>
   ```
   
   
   and `cordova build android` crashes
   
   ### Environment, Platform, Device
   Windows 10 or 11 (not sure), compiling for Android.
   
   ### Version information
   cordova-common 5.0.0
   
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   
   
   # Misc notes:
   
   This did not occur on 4.0.2, for unclear reasons.
   
   To fix this, the best way of changing this is to edit 
`ConfigChanges.prototype._is_conflicting` to deal with the way that 
`config-file` entries use `target` - basically, they use `target` where 
`edit-config` uses `file` and `parent` where `edit-config` uses `target`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to