breautek opened a new pull request, #307: URL: https://github.com/apache/cordova-plugin-media-capture/pull/307
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Using the Media Store query API requires broad range external storage permissions on API 28 and earlier (including API 29 if legacy storage rules are used). This will be important for a future PR to remove unnecessary permissions. Additionally, the logic of checking the number of images in the media store is flawed as external sources (outside of the application) can add or remove content at any time. There is no guarantee that checking the quantity of images will result in the intended behaviour of removing duplicate images. There is also no guarantee that the image selected is even the image that is a "duplicate". The Camera plugin had the same logic which was [removed](https://github.com/apache/cordova-plugin-camera/pull/907) for the same reasons. Lastly, recent changes have changed where images are stored, which is in the app's internal directory, we no longer use the external storage paths. ### Description <!-- Describe your changes in detail --> Removed code associated with checking the media store ### Testing <!-- Please describe in detail how you tested your changes. --> Ran paramedic. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
