dpogue opened a new pull request, #1516: URL: https://github.com/apache/cordova-ios/pull/1516
### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> The Cordova docs say to provide platform-specific arguments after a `--` on the CLI. Currently this works on Android, but does not work for iOS. Closes GH-1488. ### Description <!-- Describe your changes in detail --> Ensure that we parse any extra (platform-specific) arguments passed from cordova-cli in to the iOS build command through `options.argv`. These are arguments that are provided after a `--` to the CLI command. There is no change for existing arguments passed without the double dash. The priority of arguments is now: 1. Platform-specific arguments passed after a double-dash. 2. Arguments passed without a double-dash (current behaviour). 3. Values provided in a build.json config file. ### Testing <!-- Please describe in detail how you tested your changes. --> Added unit tests to cover argument parsing and fallback behaviour. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
