breautek commented on PR #1515:
URL: https://github.com/apache/cordova-ios/pull/1515#issuecomment-2552051913

   > This actually works if CordovaLib is a static library for the app target, 
but not when it's consumed as a Swift package itself (which is how we're using 
it in 8.0.0)
   
   I would have thought that this would create duplicate symbols in the app 
binary.
   
   If we have 3 targets:
   
   1. App (Produces Executable)
   2. CordovaLib (Produces Static Library)
   3. Plugin (Produces Dynamic Library)
   
   CordovaLib itself is standalone.
   Plugin would link against CordovaLib and produces an executable object (the 
shared library). If CordovaLib is static, it's symbols should be embedded into 
this shared library.
   App would link against CordovaLib & Plugin and here during linking I would 
expect duplicate symbol issues, because CordovaLib symbols will be embedded 
into both Plugin binary, and the App executable binary.
   
   This configuration would work, but only if you have no plugins, as a plugin 
that is linking with a static CordovaLib would cause duplicate symbols assuming 
that the app is also linking against the same static library. Doesn't this 
happen?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to