breautek commented on issue #572: URL: https://github.com/apache/cordova-plugin-file/issues/572#issuecomment-2528991987
> Saw this : still really evil to not follow the MDN [#316 (comment)](https://github.com/apache/cordova-plugin-file/issues/316#issuecomment-2173349010) I haven't really had a chance to take a look, but changing anything is probably going to be a hefty project unfortunately. It's not something that I can prioritise development time either. If someone wants to try to tackle this issue, then the [Dev Mailing List](https://cordova.apache.org/contact/) is a place to discuss solutions how move forward, if that solution is a big change. The plugin shouldn't be affecting Blob or ArrayBuffer symbols, I don't see anywheres where those symbols are overwritten. It does overwrite `File` and `FileReader` (and a few others, implementing the old and now defunct filesystem spec). It likely did replacements because back in the day there was probably nothing to extend as most of these symbols just simply didn't exist in webview environments. Though today that probably has changed, so extending the native browser objects and overriding bits needed to communicate over the native bridge might be feasible. This would need a PoC to test with. I did do a quick review this morning and `File` object is going to be problematic, as it doesn't seem to follow the standard at all, at least for it's constructor. The constructor params probably should change to match the standard (and then it can probably extend the native browser `File` which should satisfy Type checks and also inherit the blob features as well). Though user code shouldn't be constructing `File` objects themselves, I think `File` is still part of the public API and thus changing it would be considered a breaking change. I do agree not following the standard that it overwrites is **evil**, as far as I can tell, it always broke the specification on for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
