breautek commented on code in PR #302: URL: https://github.com/apache/cordova-plugin-media-capture/pull/302#discussion_r1867943319
########## src/android/res/xml/mediacapture_provider_paths.xml: ########## @@ -0,0 +1,21 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<paths xmlns:android="http://schemas.android.com/apk/res/android";> + <cache-path name="cache_files" path="." /> Review Comment: we should use a subdirectory for media-capture usage. The java code would have to make sure the directory exists and use it accordingly as well. This as it stands allows intents to potentially read more files than necessary which could be seen as a security risk. By using a subdirectory, that risk is mitigated down to only files that this plugin created, which is fine because this is used to instruct intents to write new data to this location. Does this make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
