erisu commented on PR #1746:
URL: https://github.com/apache/cordova-android/pull/1746#issuecomment-2472306721

   > I believe the polling implementation was brought into the main exec file, 
and still exists here:
   > 
   > 
https://github.com/apache/cordova-android/blob/5a2c50d1ed67c1cdad0d12f1b6fbbd04ab55dff6/cordova-js-src/exec.js#L120-L132
   > 
   > I don't know whether that means we should be calling it from Java or 
not... clearly this has been broken for a long while
   
   Might be able to expose that method by added it to `androidExec`: 
   
   ```javascript
   androidExec.pollOnce = pollOnce;
   ```
   
   Then instead of deleting the line, update it to:
   
   ```java
               if (!willSendAllMessages) {
                   
sb.append("window.setTimeout(function(){cordova.require('cordova/exec').pollOnce();},0);");
               }
   ```
   
   But I don't know what the behavior it will have after adding a pollOnce call 
to something that never ran for 12 years...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to