breautek opened a new pull request, #913: URL: https://github.com/apache/cordova-plugin-camera/pull/913
…ats of getPicture <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Documentation ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Added notes mostly in regards to the public API changes for the return format of `getPicture`. Also improved documentation surrounding best practices. ### Description <!-- Describe your changes in detail --> - Added notes about return formats in v8+ - Added notes about the return formats used in v7 and earlier - Removed `createFileEntry` example, doesn't seem relevant to the camera plugin anymore. - Added `copyTo` example, as should be a common pattern starting in v8 moving forward. - Added upload example, using standard browser APIs. - Added example of how to render content when data uris used. - Added example of how to render content when file uri is used, via `fileEntry.toURL()` - Added notes indicating that returned file uris are temporary access grants only that typically only survive until the app is closed. For camera captures, this isn't completely true as app cache directory are used and it will survive much longer, but I feel it is easier to treat it as short-lived temporary for the purposes of illustrating the concept in general. (`cleanup` should be used anyway which will clean up these temporary files) - Added notes stating that the `FILE_URI` returns is an implementation detail, and they should not assume it will always be `content://` or `file://`, etc... This is especially true for android devices. ### Testing <!-- Please describe in detail how you tested your changes. --> VSCode markdown preview ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
