[PR] fix(addHelper): Apply plugins sort from package.json [cordova-lib]

[via GitHub]

MaximBelov opened a new pull request, #933:
URL: https://github.com/apache/cordova-lib/pull/933

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Any
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   Different installation orders for currently installed plugins
   
   iOS
   
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort/blob/20ab95bca8aef992aa5b1982b38e5e6d750580a8/plugins/ios.json
   
   Android
   
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort/blob/20ab95bca8aef992aa5b1982b38e5e6d750580a8/plugins/android.json
   
   Plugins installation order should be the same for any platform and have the 
source of faithful from package.json
   
   Why is this important?
   The plugin `cordova-plugin-firebasex` runs a hook that adds a new Build 
Phase "Crashlytics", which should be the last one
   https://github.com/dpa99c/cordova-plugin-firebasex/pull/897
   
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   ### Description
   <!-- Describe your changes in detail -->
   How to reproduce
   
   https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   How to reproduce 
   Repository: 
https://github.com/MaximBelov/reproduce-cordova-apply-plugins-sort
   
   **Version without patch**
   
   ```sh
   git checkout master
   npm run build
   git diff  --no-index plugins/ios.json plugins/android.json
   
   ```
   Result:  
   
![image](https://github.com/user-attachments/assets/cc5befae-24bd-459d-a42c-083c6f6991d1)
   __________
   
   **Version with patch**
   
   ```sh
   
   git checkout patch
   npm run build
   git diff  --no-index plugins/ios.json plugins/android.json
   
   ```
   Result:
   
![image](https://github.com/user-attachments/assets/a0b1fcc6-34c6-4b56-b807-996631f94285)
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org