kumo01GitHub opened a new pull request, #280: URL: https://github.com/apache/cordova-plugin-geolocation/pull/280
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> - This is change for check Location Service enabled before request permission.\ For now when the location service is unavailable, the plugin request permission, open dialog and wait for timeout. Referencing `Note: Browser permission VS OS permission` in [W3C](https://w3c.github.io/geolocation/#introduction), I interpreted location service availability is similar to OS permission and it should return [PERMISSION_DENIED](https://w3c.github.io/geolocation/#dom-geolocationpositionerror-permission_denied). - In [W3C](https://w3c.github.io/geolocation/#introduction), it looks no distinction between fine and coarse location permissions. And WebView return coarse location ignoring `enableHighAccuracy` when denied permission for fine location. ### Description <!-- Describe your changes in detail --> - When request high accuracy location but only granted coarse location, onRequestPermissionResult() return `PluginResult.Status.OK` - check location service before permission. ### Testing <!-- Please describe in detail how you tested your changes. --> I checked with virtual device location service on/off. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
