dpogue opened a new pull request, #1485: URL: https://github.com/apache/cordova-ios/pull/1485
### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Currently, the generated Xcode project uses the application name for both the project and the target name. This means that file paths in generated projects are not consistent and we have to do regex-based token replacements during project creation. It also makes modifying the template project a pain because opening the template project directly in Xcode causes a bunch of those tokens to break. The deeper problem is that some tooling (notably Cocoapods) struggles with project and target names with non-ASCII characters. Possibly closes GH-717. Possibly closes GH-1150. Possibly closes GH-1289. Closes GH-1464. ### Description <!-- Describe your changes in detail --> Remaining work: - [ ] Set the `PRODUCT_NAME` to the config.xml name value so that the resulting app/ipa file has the expected name - [ ] See if we can set `PRODUCT_BUNDLE_IDENTIFIER` in a better way at create-time to avoid token replacement - [ ] Test with https://github.com/apache/cordova-common/pull/212 to see if we can rename `App-Info.plist` to just `Info.plist` - [ ] Test with Cocoapods to make sure they still work as expected - [ ] Test with Cocoapods and non-ASCII project names to ensure everything works ### Testing <!-- Please describe in detail how you tested your changes. --> All unit tests pass. Tested manually with mobilespec. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
