dpogue commented on code in PR #1430:
URL: https://github.com/apache/cordova-ios/pull/1430#discussion_r1737222904
##########
lib/Api.js:
##########
@@ -279,6 +279,11 @@ class Api {
return this.addPodSpecs(plugin, podSpecs, installOptions);
}
})
+ .then(() => {
+ if (plugin != null && plugin.dir &&
fs.existsSync(path.join(plugin.dir, 'Package.swift'))) {
Review Comment:
Looking at this PR again, and the one thing I don't really love is the
"magic" behaviour based on the existence of a Package.swift file in the plugin
folder. It feels safer to rely on an explicit declaration in the plugin.xml
file.
We've already overloaded the `<framework>` tag to do a billion things, so
adding this wouldn't be totally unreasonable. i.e.,
```xml
<framework src="Package.swift" type="spm" />
```
Alternatively, the `lib-file` tag exists on Android but you could maybe
stretch the definition to encompass Swift packages.
Using `source-file` is an option, but feels like that goes back to "magic"
behaviour based on file names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
