BBlashko opened a new pull request, #1471: URL: https://github.com/apache/cordova-ios/pull/1471
…ading requests <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected - iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> There is a problem with iOS where the diskcache aka .js, html, and css etc files are cached between .ipa installs. When updating `.ipa` bundles in the Apple AppStore, it was evident that when using the `fileURL` system the WKWebView holds onto a previously cached cordova framework files. This can result in a fatal when booting the application if you remove a plugin. If this happens the `cordova_plugins.js` file doesn't get updated, so it tries to load the deleted plugin. This creates a hard blocking result, since the plugin files don't exist, so cordova cannot load the plugin (even though it should be removed) There is no issue for this at this time, I was discussing it with Norman Breau in the Slack Space ### Description <!-- Describe your changes in detail --> This is a follow up Pull Request to this request: https://github.com/apache/cordova-ios/pull/1451 Instead of flushing cache at the boot of the cordova framework. It was suggested to just ignore local cache when `loadRequest()` is called. So when cordova runs the `loadRequest` function in the `CDVWebViewEngine.m` file, we apply a `NSURLRequestReloadIgnoringLocalCacheData ` cache policy to the request. This should ignore any cached instances and pull the files directly ### Testing <!-- Please describe in detail how you tested your changes. --> Loaded our local dev app with the new policy applied to requests. Inspected the Network of the device to track down if the app is using files from the WKWebView Cache or not. We also are still getting these errors into our error reporting systems. ``` Module branch-cordova-sdk.Branch does not exist. ``` I can validate that these start to stop coming in completely on the new version of our production application. ### Checklist - [*] I've run the tests to see all new and existing tests pass - [*] I added automated test coverage as appropriate for this change - [*] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [*] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [*] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
