dpogue opened a new pull request, #1455: URL: https://github.com/apache/cordova-ios/pull/1455
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Closes #1428. ### Description <!-- Describe your changes in detail --> * Added deprecation annotations to things we want to discourage people from using (some of these can be removed in Cordova iOS 9) * Remove some conditionals for iOS versions pre-11 and dead code * Change CDVPlugin's `viewController` from a `UIViewController*` to a `CDVViewController*` * Move a webview engine-related delegate to a header that makes more sense ### Testing <!-- Please describe in detail how you tested your changes. --> Unit tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
