breautek commented on code in PR #1339:
URL: https://github.com/apache/cordova-docs/pull/1339#discussion_r1679132631
##########
www/docs/en/dev/config_ref/images.md:
##########
@@ -34,7 +34,7 @@ When working in the CLI you can define application icon(s)
via the `<icon>` elem
If you do not specify an icon, the Apache Cordova logo is used.
```xml
- <icon src="res/ios/icon.png" platform="ios" width="57" height="57"
density="mdpi" />
+ <icon src="res/ios/icon.png" platform="ios" width="57" height="57" />
Review Comment:
We are removing the density example here but I understand your rationale
since the platorm `ios` in the example.
The `density` attribute is also missing in the table below. Maybe we should
add it there. I believe `density` is optional, even for android, though it
should be set if the `src` is a rasterized image (like PNG). I think `{%
cdv_platform android %}` can be used to display the android icon, to indicate
that it's an android only attribute. The `target` format can be followed to
produce the `density` table row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
