dpogue opened a new pull request, #1437: URL: https://github.com/apache/cordova-ios/pull/1437
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Closes GH-1120. Closes GH-1121. Closes GH-1429. ### Description <!-- Describe your changes in detail --> In cases where the system was presenting something on the screen (such as a permission prompt, or an undo dialog) or in cases where the `CDVViewController` was not the root view controller (such as in a tabbed navigator), trying to show any dialogs triggered from the WebView would attempt to create an alert on the root view controller and get the view hierarchy into a bad state. Now, we only try to display alerts on the `CDVViewController` that owns the WebView. This means that alerts can potentially end up behind other system dialogs, but the view controller no longer freezes. (As an aside, having access to the `CDVViewController` here will be helpful for some future things too...) ### Testing <!-- Please describe in detail how you tested your changes. --> Tested manually by triggering an alert while a permission prompt was being displayed and confirmed that the app continued working as expected. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
