dpogue opened a new pull request, #1436:
URL: https://github.com/apache/cordova-ios/pull/1436

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Fixes GH-1423 (based on the comment on 
https://github.com/apache/cordova-ios/commit/4c8136345ae9622646ee7e4eb60ba2b37ad44fbe#r142043240)
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Check that the engine class instance responds to the 
`initWithFrame:configuration:` selector rather than the engine class itself 
(because it's not a static class method).
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   All unit tests pass, but I don't think we have test coverage for this 
particular feature.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to